fix: add storage ui launch tests #1821
Conversation
Summary of ChangesHello @ncooke3, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed! This pull request introduces initial UI testing capabilities for the Highlights
Using Gemini Code AssistThe full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips. Invoking Gemini You can request assistance from Gemini at any point by creating a comment using either
Customization To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a Limitations & Feedback Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here. You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension. Footnotes
|
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
There was a problem hiding this comment.
Code Review
This pull request adds a new UI test target and corresponding template files for the iOS StorageExample. My review focuses on improving the boilerplate code in the newly added test files. I've suggested removing unnecessary comments, adding required calls to super in setUpWithError methods, and making the placeholder test more meaningful. These changes will improve the correctness and readability of the new test code.
| override func setUpWithError() throws { | ||
| // Put setup code here. This method is called before the invocation of each test method in the class. | ||
|
|
||
| // In UI tests it is usually best to stop immediately when a failure occurs. | ||
| continueAfterFailure = false | ||
|
|
||
| // In UI tests it’s important to set the initial state - such as interface orientation - required for your tests before they run. The setUp method is a good place to do this. | ||
| } |
There was a problem hiding this comment.
Boilerplate comments should be removed to improve readability. Also, it's required to call super.setUpWithError() when overriding this method.
override func setUpWithError() throws {
try super.setUpWithError()
continueAfterFailure = false
}
There was a problem hiding this comment.
@ncooke3 I think you can just delete all the generated override stubs in this file.
| override func tearDownWithError() throws { | ||
| // Put teardown code here. This method is called after the invocation of each test method in the class. | ||
| } |
There was a problem hiding this comment.
This method is empty, but when overriding tearDownWithError, you must call super.tearDownWithError(). Since there is no other teardown logic, this method can be removed entirely. If you intend to add logic later, ensure you include the super call.
storage/StorageExample_iOS_UITests/StorageExampleUITestsLaunchTests.swift
Show resolved
Hide resolved
storage/StorageExample_iOS_UITests/StorageExampleUITestsLaunchTests.swift
Show resolved
Hide resolved
|
Not sure why the check is failing. I'll consider it non-blocking. |
| override func setUpWithError() throws { | ||
| // Put setup code here. This method is called before the invocation of each test method in the class. | ||
|
|
||
| // In UI tests it is usually best to stop immediately when a failure occurs. | ||
| continueAfterFailure = false | ||
|
|
||
| // In UI tests it’s important to set the initial state - such as interface orientation - required for your tests before they run. The setUp method is a good place to do this. | ||
| } |
There was a problem hiding this comment.
@ncooke3 I think you can just delete all the generated override stubs in this file.
2 participants
This unblocks firebase/firebase-ios-sdk#15609